Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readings in The King of Trees #431

Merged
merged 3 commits into from
Jun 29, 2020
Merged

Readings in The King of Trees #431

merged 3 commits into from
Jun 29, 2020

Conversation

mira-gruenwald
Copy link
Collaborator

Pull-requests should be ready to merge, that is free of conflicts, and they should pass our testsuite. If you require a specific reviewer you can request a review on the right.

Please indicate issues related to this PR (if any)

See #429 .
Close # .

Checklist

  • The title line explains what these changes do
  • All my changes are marked in the last_modfied column
  • The PR has no merge conflicts
  • Travis checks are passing

duncdrum
duncdrum reviewed Jun 29, 2020
View reviewed changes
Copy link
Member

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite get what's happening with all the anon person entries, are these just missing translation? unnamed persona which are distinct from P0999 …

@mira-gruenwald
Copy link
Collaborator Author

Yes, they are unnamed, but not unknown. P1076 is the narrator (in this case first-person), so I put 'anon' since there was no name given.

@duncdrum duncdrum mentioned this pull request Jun 29, 2020
Open
duncdrum
duncdrum approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok lets stick with anon for now i have to think about how best to approach this for the 2.0 release.
see #432

@duncdrum duncdrum merged commit d979b4f into 2.0-fiction Jun 29, 2020
@duncdrum duncdrum deleted the the-king-of-trees branch June 29, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncdrum duncdrum duncdrum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mira-gruenwald @duncdrum